From cd33bb1ce6f2ed0f1681bdd4317df88a66a52fae Mon Sep 17 00:00:00 2001 From: whaffman Date: Tue, 21 Oct 2025 23:47:21 +0200 Subject: [PATCH] refactor(CgiProcess): update TODO comment for pipe handling to improve clarity --- webserv/handler/CgiProcess.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/webserv/handler/CgiProcess.cpp b/webserv/handler/CgiProcess.cpp index 954efa9..5b024e2 100644 --- a/webserv/handler/CgiProcess.cpp +++ b/webserv/handler/CgiProcess.cpp @@ -32,7 +32,8 @@ void CgiProcess::spawn() auto cgiPath = uri.getCgiPath(); // pipes - + // TODO pipe can handle flags O_CLOEXEC | O_NONBLOCK as open we should use this everywhere, then we dont need to set + // non blocking and the fd will be closed when exec is run int pipeStdin[2]; int pipeStdout[2]; int pipeStderr[2];