From 68ea191460c42bf253bb9e995d83236f023c9b86 Mon Sep 17 00:00:00 2001 From: Quinten Date: Tue, 14 Oct 2025 19:02:49 +0200 Subject: [PATCH] refactor: remove unused Router references from Client and Server classes --- webserv/client/Client.cpp | 2 -- webserv/client/Client.hpp | 1 - webserv/server/Server.cpp | 7 +------ webserv/server/Server.hpp | 2 -- 4 files changed, 1 insertion(+), 11 deletions(-) diff --git a/webserv/client/Client.cpp b/webserv/client/Client.cpp index 1e1ac5b..7a351eb 100644 --- a/webserv/client/Client.cpp +++ b/webserv/client/Client.cpp @@ -97,8 +97,6 @@ std::vector Client::getResponse() const { Log::trace(LOCATION); - const Router &router = server_.getRouter(); - static_cast(router); // Suppress unused variable warning auto response = Router::handleRequest(*httpRequest_); return response->toBytes(); } \ No newline at end of file diff --git a/webserv/client/Client.hpp b/webserv/client/Client.hpp index 32b6622..a300919 100644 --- a/webserv/client/Client.hpp +++ b/webserv/client/Client.hpp @@ -8,7 +8,6 @@ #include // for HttpResponse #include #include // for ClientSocket -#include #include // for size_t #include // for uint8_t diff --git a/webserv/server/Server.cpp b/webserv/server/Server.cpp index b1e6e85..916c22d 100644 --- a/webserv/server/Server.cpp +++ b/webserv/server/Server.cpp @@ -27,7 +27,7 @@ class Router; Server::Server(const ConfigManager &configManager) - : epoll_fd_(epoll_create1(0)), configManager_(configManager), router_() + : epoll_fd_(epoll_create1(0)), configManager_(configManager) { Log::trace(LOCATION); const auto &serverConfigs = configManager.getServerConfigs(); @@ -243,9 +243,4 @@ void Server::run() handleEvent(&events[i]); // NOLINT(cppcoreguidelines-pro-bounds-constant-array-index) } } -} - -const Router &Server::getRouter() const -{ - return router_; } \ No newline at end of file diff --git a/webserv/server/Server.hpp b/webserv/server/Server.hpp index 034ce73..199c352 100644 --- a/webserv/server/Server.hpp +++ b/webserv/server/Server.hpp @@ -43,12 +43,10 @@ class Server ServerSocket &getListener(int fd) const; Client &getClient(int fd) const; - const Router &getRouter() const; private: int epoll_fd_; const ConfigManager &configManager_; - const Router router_; std::vector> listeners_; std::set listener_fds_; // std::unordered_map> clients_;