willem/webserv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: change magic 504 to constant

Browse Source
This commit is contained in:
Quinten 2025-11-12 11:51:09 +01:00
parent 0138883af6
commit 05b8ebf61b
5 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webserv/handler/CgiHandler.cpp
View File

@ -1,3 +1,4 @@
#include "webserv/http/HttpConstants.hpp"
#include <webserv/client/Client.hpp> // for Client #include <webserv/client/Client.hpp> // for Client
#include <webserv/handler/CgiHandler.hpp> #include <webserv/handler/CgiHandler.hpp>
#include <webserv/handler/CgiProcess.hpp> // for CgiProcess #include <webserv/handler/CgiProcess.hpp> // for CgiProcess
@ -342,7 +343,7 @@ void CgiHandler::handleTimeout()
Log::info("Terminated CGI process with PID: " + std::to_string(pid_)); Log::info("Terminated CGI process with PID: " + std::to_string(pid_));
} }
ErrorHandler::createErrorResponse(504, response_); ErrorHandler::createErrorResponse(Http::StatusCode::GATEWAY_TIMEOUT, response_);
// cancelTimer(); // cancelTimer();
} }

2
webserv/handler/DeleteHandler.cpp
View File

@ -73,5 +73,5 @@ void DeleteHandler::deleteDirectory(const std::string &path)
void DeleteHandler::handleTimeout() void DeleteHandler::handleTimeout()
{ {
Log::debug("DeleteHandler: Request timed out"); Log::debug("DeleteHandler: Request timed out");
ErrorHandler::createErrorResponse(504, response_, request_.getUri().getConfig()); ErrorHandler::createErrorResponse(Http::StatusCode::GATEWAY_TIMEOUT, response_, request_.getUri().getConfig());
} }

2
webserv/handler/FileHandler.cpp
View File

@ -24,7 +24,7 @@ FileHandler::FileHandler(const HttpRequest &request, HttpResponse &response)
void FileHandler::handleTimeout() void FileHandler::handleTimeout()
{ {
Log::warning("File handler timeout occurred for path: " + uri_.getFullPath()); Log::warning("File handler timeout occurred for path: " + uri_.getFullPath());
ErrorHandler::createErrorResponse(504, response_, config_); ErrorHandler::createErrorResponse(Http::StatusCode::GATEWAY_TIMEOUT, response_, config_);
} }
void FileHandler::handleFile(const std::string &filepath) const void FileHandler::handleFile(const std::string &filepath) const

2
webserv/handler/RedirectHandler.cpp
View File

@ -34,6 +34,6 @@ void RedirectHandler::handleTimeout()
{ {
Log::warning("Redirect handler timeout occurred for path: " + request_.getUri().getFullPath()); Log::warning("Redirect handler timeout occurred for path: " + request_.getUri().getFullPath());
ErrorHandler::createErrorResponse(504, response_, request_.getUri().getConfig()); ErrorHandler::createErrorResponse(Http::StatusCode::GATEWAY_TIMEOUT, response_, request_.getUri().getConfig());
} }

1
webserv/http/HttpConstants.hpp
View File

@ -53,6 +53,7 @@ constexpr uint16_t INTERNAL_SERVER_ERROR = 500;
constexpr uint16_t NOT_IMPLEMENTED = 501; constexpr uint16_t NOT_IMPLEMENTED = 501;
constexpr uint16_t BAD_GATEWAY = 502; constexpr uint16_t BAD_GATEWAY = 502;
constexpr uint16_t SERVICE_UNAVAILABLE = 503; constexpr uint16_t SERVICE_UNAVAILABLE = 503;
constexpr uint16_t GATEWAY_TIMEOUT = 504;
} // namespace StatusCode } // namespace StatusCode
struct StatusCodeInfo struct StatusCodeInfo