willem/minishell
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unused parameter

Browse Source
This commit is contained in:
whaffman 2025-03-27 10:45:45 +01:00
parent 33a428e81e
commit da6f69b575
4 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -4,6 +4,14 @@ A lot of amazing shell stuff
- libreadline-dev - libreadline-dev
- libncurses-dev - libncurses-dev
##EVALS
- [ ] exit code niet perse de laatste command race condition?
- [ ] heredoc quote + variable expansion
## Comments on work ## Comments on work
- Checked if path is a directory and send appropriate message - Checked if path is a directory and send appropriate message
- `executor_absolute_path` => extracted some code into helpers to make it norminette compliant - `executor_absolute_path` => extracted some code into helpers to make it norminette compliant

5
inc/parser.h
View File

@ -6,7 +6,7 @@
/* By: qmennen <qmennen@student.codam.nl> +#+ */ /* By: qmennen <qmennen@student.codam.nl> +#+ */
/* +#+ */ /* +#+ */
/* Created: 2025/02/11 14:03:03 by qmennen #+# #+# */ /* Created: 2025/02/11 14:03:03 by qmennen #+# #+# */
/* Updated: 2025/03/17 14:00:03 by whaffman ######## odam.nl */ /* Updated: 2025/03/25 10:54:35 by whaffman ######## odam.nl */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -26,7 +26,6 @@ char **parser_get_arguments(t_minishell *msh,
int parser_validate_command(t_command *command); int parser_validate_command(t_command *command);
int parser_count_arguments(t_list *list); int parser_count_arguments(t_list *list);
char *parser_concatenate(t_minishell *msh, char *str1, char *str2); char *parser_concatenate(t_minishell *msh, char *str1, char *str2);
char *parser_process_token(t_minishell *msh, char *parser_process_token(t_minishell *msh, t_list *t_head);
t_list *prev, t_list *t_head);
#endif #endif

4
src/parser/parser_get_arguments.c
View File

@ -6,7 +6,7 @@
/* By: qmennen <qmennen@student.codam.nl> +#+ */ /* By: qmennen <qmennen@student.codam.nl> +#+ */
/* +#+ */ /* +#+ */
/* Created: 2025/02/11 16:20:09 by qmennen #+# #+# */ /* Created: 2025/02/11 16:20:09 by qmennen #+# #+# */
/* Updated: 2025/03/17 13:59:28 by whaffman ######## odam.nl */ /* Updated: 2025/03/25 10:55:15 by whaffman ######## odam.nl */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -46,7 +46,7 @@ char **parser_get_arguments(t_minishell *msh,
{ {
if (token_from_list(cur)->type < 3) if (token_from_list(cur)->type < 3)
{ {
str = parser_process_token(msh, token_list_index(list, i - 1), cur); str = parser_process_token(msh, cur);
if (parser_should_concact(msh, i, cur, prev)) if (parser_should_concact(msh, i, cur, prev))
args[i - 1] = parser_concatenate(msh, args[i - 1], str); args[i - 1] = parser_concatenate(msh, args[i - 1], str);
else if (str) else if (str)

4
src/parser/parser_process_token.c
View File

@ -6,7 +6,7 @@
/* By: qmennen <qmennen@student.codam.nl> +#+ */ /* By: qmennen <qmennen@student.codam.nl> +#+ */
/* +#+ */ /* +#+ */
/* Created: 2025/03/05 21:12:15 by qmennen #+# #+# */ /* Created: 2025/03/05 21:12:15 by qmennen #+# #+# */
/* Updated: 2025/03/25 09:44:22 by whaffman ######## odam.nl */ /* Updated: 2025/03/25 10:54:00 by whaffman ######## odam.nl */
/* */ /* */
/* ************************************************************************** */ /* ************************************************************************** */
@ -42,7 +42,7 @@ static int parser_should_expand(t_list *value)
//TODO: Make an exception for this `echo hey""you "" test`. //TODO: Make an exception for this `echo hey""you "" test`.
// here echo actually interprets "" as an extra space. Just check if // here echo actually interprets "" as an extra space. Just check if
// its empty and surrounded by spaces or sth. Can't be asked rn // its empty and surrounded by spaces or sth. Can't be asked rn
char *parser_process_token(t_minishell *msh, t_list *prev, t_list *t_head) char *parser_process_token(t_minishell *msh, t_list *t_head)
{ {
char *str; char *str;
t_token *token; t_token *token;